Add graphql endpoints for querying asset check automation history #26170
+172
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+193
to
+197
| def resolve_automationCondition( | ||
| self, _graphene_info: ResolveInfo | ||
| ) -> Optional[GrapheneAutoMaterializePolicy]: | ||
| automation_condition = ( |
There was a problem hiding this comment.
The return type annotation Optional[GrapheneAutoMaterializePolicy] doesn't match the actual return type of this method, which is Optional[GrapheneAutomationCondition]. This mismatch could cause type checking errors and make the code harder to maintain. Please update the type annotation to match the implementation.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
OwenKephart
force-pushed
the
11-27-add_graphql_endpoints_for_querying_asset_check_automation_history
branch
from
d47d9b3 to
679ac0d
Compare
OwenKephart
force-pushed
the
11-27-add_graphql_endpoints_for_querying_asset_check_automation_history
branch
from
679ac0d to
d02efc2
Compare
OwenKephart
force-pushed
the
11-27-add_graphql_endpoints_for_querying_asset_check_automation_history
branch
from
d02efc2 to
76f99d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As title
How I Tested These Changes
Changelog
NOCHANGELOG