-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10/n] [RFC] Implement updated designs: Schedules [4/N] #26179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 101573e. |
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-4
branch
from
December 3, 2024 19:07
86a2d6a
to
95738ed
Compare
salazarm
reviewed
Dec 3, 2024
js_modules/dagster-ui/packages/ui-core/src/ticks/EvaluateScheduleDialog.tsx
Outdated
Show resolved
Hide resolved
salazarm
approved these changes
Dec 3, 2024
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-4
branch
from
December 3, 2024 20:12
95738ed
to
3d4c8b3
Compare
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-3
branch
from
December 5, 2024 21:45
074b102
to
966f22d
Compare
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-4
branch
from
December 5, 2024 21:49
3d4c8b3
to
c4ced5f
Compare
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-3
branch
from
December 6, 2024 15:41
f886d54
to
a35758e
Compare
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-4
branch
from
December 6, 2024 15:41
c4ced5f
to
7b8782b
Compare
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-3
branch
from
December 9, 2024 17:44
a35758e
to
25997a2
Compare
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-4
branch
from
December 9, 2024 17:45
7b8782b
to
101573e
Compare
dliu27
added a commit
that referenced
this pull request
Dec 9, 2024
## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-708/implement-updated-designs-schedule-[4n] Video: https://github.com/user-attachments/assets/0f8cea65-aef7-44f7-833e-fa111b82b703 ## How I Tested These Changes jest, yarn lint, ts, tested locally for all cases: Multiple run requests, skipped, exception ## Changelog [ui] improved ui for manual sensor/schedule evaluation
dliu27
added a commit
to dliu27/dagster-fork
that referenced
this pull request
Dec 9, 2024
…6179) ## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-708/implement-updated-designs-schedule-[4n] Video: https://github.com/user-attachments/assets/0f8cea65-aef7-44f7-833e-fa111b82b703 ## How I Tested These Changes jest, yarn lint, ts, tested locally for all cases: Multiple run requests, skipped, exception ## Changelog [ui] improved ui for manual sensor/schedule evaluation
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…6179) ## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-708/implement-updated-designs-schedule-[4n] Video: https://github.com/user-attachments/assets/0f8cea65-aef7-44f7-833e-fa111b82b703 ## How I Tested These Changes jest, yarn lint, ts, tested locally for all cases: Multiple run requests, skipped, exception ## Changelog [ui] improved ui for manual sensor/schedule evaluation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Linear: https://linear.app/dagster-labs/issue/FE-708/implement-updated-designs-schedule-[4n]
Video:
Recording.at.2024-11-27.15.49.24.mp4
How I Tested These Changes
jest, yarn lint, ts, tested locally for all cases: Multiple run requests, skipped, exception
Changelog
[ui] improved ui for manual sensor/schedule evaluation