[2/n][dagster-airbyte] Scaffold DagsterAirbyteTranslator for rework #26205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
9
to
10
| class AirbyteConnectionTableProps(NamedTuple): | ||
| ... |
There was a problem hiding this comment.
NamedTuple requires at least one field to be defined. If this is intended as a placeholder for future development, use pass instead of ... to make the placeholder explicit.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
maximearmstrong
force-pushed
the
maxime/rework-airbyte-cloud-1
branch
from
64d2d52 to
93a7844
Compare
maximearmstrong
force-pushed
the
maxime/rework-airbyte-cloud-2
branch
from
b1a69b1 to
0d85429
Compare
| from dagster._serdes.serdes import whitelist_for_serdes | ||
|
|
||
|
|
||
| class AirbyteConnectionTableProps(NamedTuple): ... |
There was a problem hiding this comment.
AirbyteConnectionTableProps is currently defined as an empty NamedTuple. Since this class is used as a parameter type in get_asset_spec(), it needs to have its fields defined to be instantiated correctly at runtime. Consider adding the required fields to the NamedTuple definition.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
maximearmstrong
changed the title
This was referenced Dec 3, 2024
|
I'm assuming the upstack is meant to be non-draft as well? |
maximearmstrong
force-pushed
the
maxime/rework-airbyte-cloud-1
branch
from
93a7844 to
215d8cf
Compare
maximearmstrong
force-pushed
the
maxime/rework-airbyte-cloud-2
branch
from
2dc0534 to
9c0212c
Compare
dpeng817
requested changes
Dec 3, 2024
maximearmstrong
force-pushed
the
maxime/rework-airbyte-cloud-2
branch
from
9c0212c to
2930c7f
Compare
maximearmstrong
force-pushed
the
maxime/rework-airbyte-cloud-1
branch
from
6f017c1 to
71679a8
Compare
maximearmstrong
force-pushed
the
maxime/rework-airbyte-cloud-2
branch
from
2930c7f to
8645142
Compare
maximearmstrong
force-pushed
the
maxime/rework-airbyte-cloud-1
branch
from
71679a8 to
630699b
Compare
maximearmstrong
force-pushed
the
maxime/rework-airbyte-cloud-2
branch
from
8645142 to
f19ad83
Compare
maximearmstrong
force-pushed
the
maxime/rework-airbyte-cloud-1
branch
from
630699b to
0aad3f9
Compare
maximearmstrong
force-pushed
the
maxime/rework-airbyte-cloud-2
branch
from
f19ad83 to
8397e6a
Compare
dpeng817
approved these changes
Dec 5, 2024
maximearmstrong
force-pushed
the
maxime/rework-airbyte-cloud-2
branch
from
8397e6a to
1df12dd
Compare
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…agster-io#26205) ## Summary & Motivation Builds out a very barebones translator and props classes for the new version of the Airbyte cloud integration. ## How I Tested These Changes Tests will be added in subsequent PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Builds out a very barebones translator and props classes for the new version of the Airbyte cloud integration.
How I Tested These Changes
Tests will be added in subsequent PRs.