[11/n] [RFC] add jest tests #26249
Merged
[11/n] [RFC] add jest tests #26249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 1759d79. |
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-4
branch
from
86a2d6a to
95738ed
Compare
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-5
branch
from
0301597 to
e131c31
Compare
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-4
branch
from
95738ed to
3d4c8b3
Compare
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-5
branch
from
e131c31 to
a701abc
Compare
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-4
branch
from
3d4c8b3 to
c4ced5f
Compare
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-5
branch
from
c6e9fef to
24d601b
Compare
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-4
branch
from
c4ced5f to
7b8782b
Compare
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-5
branch
from
24d601b to
8f73433
Compare
salazarm
reviewed
Dec 6, 2024
...dules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/EvaluateScheduleDialog.fixtures.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Dec 6, 2024
...dules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/EvaluateScheduleDialog.fixtures.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Dec 6, 2024
...dules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/EvaluateScheduleDialog.fixtures.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Dec 6, 2024
js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/SensorDryRunDialog.fixtures.tsx
Show resolved
Hide resolved
salazarm
reviewed
Dec 6, 2024
| { | ||
| runConfigData: | ||
| 'solids:\n read_file:\n config:\n directory: /Users/marcosalazar/code/dagster/js_modules/dagster-ui/packages/ui-core/src/ticks/tests\n filename: DryRunRequestTable.test.tsx', | ||
| selector: { |
salazarm
reviewed
Dec 6, 2024
|
|
||
| it('launches all runs', async () => { | ||
| const pushSpy = jest.fn(); | ||
| const createHrefSpy = jest.fn(); |
There was a problem hiding this comment.
you didn't actually use thsis variable
There was a problem hiding this comment.
had to include this cuz since I'm mocking useHistory
I get the error: TypeError: history.createHref is not a function
without it
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-4
branch
from
7b8782b to
101573e
Compare
An error occurred while trying to automatically change base from
dliu27/manual-tick-design-tweaks-4
to
master
December 9, 2024 17:46
dliu27
force-pushed
the
dliu27/manual-tick-design-tweaks-5
branch
from
9c99eb6 to
1759d79
Compare
dliu27
changed the base branch from
dliu27/manual-tick-design-tweaks-4
to
master
salazarm
approved these changes
Dec 9, 2024
dliu27
added a commit
that referenced
this pull request
Dec 9, 2024
## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-713/add-jest-tests-for-sensors-and-schedules Adds jest tests for launch all ## How I Tested These Changes yarn jest, ts, lint
dliu27
added a commit
to dliu27/dagster-fork
that referenced
this pull request
Dec 9, 2024
## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-713/add-jest-tests-for-sensors-and-schedules Adds jest tests for launch all ## How I Tested These Changes yarn jest, ts, lint
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-713/add-jest-tests-for-sensors-and-schedules Adds jest tests for launch all ## How I Tested These Changes yarn jest, ts, lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Linear: https://linear.app/dagster-labs/issue/FE-713/add-jest-tests-for-sensors-and-schedules
Adds jest tests for launch all
How I Tested These Changes
yarn jest, ts, lint