Fix asset catalog loading state showing "No assets found" while asset selection filtering is loading. #26291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangenfeld
approved these changes
Dec 5, 2024
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 5bdf89e. |
cmpadden
pushed a commit
that referenced
this pull request
Dec 5, 2024
… selection filtering is loading. (#26291) ## Summary & Motivation We added asset selection based filtering to the catalog page but need to make sure the page properly waits for that filtering to occurring ## How I Tested These Changes app-proxy
gibsondan
pushed a commit
that referenced
this pull request
Dec 5, 2024
… selection filtering is loading. (#26291) ## Summary & Motivation We added asset selection based filtering to the catalog page but need to make sure the page properly waits for that filtering to occurring ## How I Tested These Changes app-proxy
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
… selection filtering is loading. (dagster-io#26291) ## Summary & Motivation We added asset selection based filtering to the catalog page but need to make sure the page properly waits for that filtering to occurring ## How I Tested These Changes app-proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We added asset selection based filtering to the catalog page but need to make sure the page properly waits for that filtering to occurring
How I Tested These Changes
app-proxy