[ui] Move CodeMirror-based components out of main ui-components export #26304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 59d304b. |
dliu27
approved these changes
Dec 6, 2024
|
Going to push up an additional change to fix the build. |
hellendag
force-pushed
the
dish/separate-codemirror-from-ui-components
branch
from
a33571a to
aab3109
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 59d304b. |
hellendag
force-pushed
the
dish/separate-codemirror-from-ui-components
branch
2 times, most recently
from
2aee32e to
45160d8
Compare
bengotow
approved these changes
Dec 9, 2024
| format: 'cjs', | ||
| sourcemap: true, | ||
| { | ||
| input: './src/editor.ts', |
[INTERNAL_BRANCH=dish/plus-components-editor]
hellendag
force-pushed
the
dish/separate-codemirror-from-ui-components
branch
from
45160d8 to
59d304b
Compare
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
dagster-io#26304) ## Summary & Motivation The CodeMirror-based components in `ui-components` are adding quite a bit of CSS bloat via automatic imports, and the implicit use of `navigator` breaks static rendering in Next.js apps. Split them out into an `editor` export, which can be used via `@dagster-io/ui-components/lib/editor`. It would probably be good to split the library up further, but this is at least a step in the right direction. ## How I Tested These Changes TS, lint, jest. `yarn build` for the component library, verify that it builds correctly and that CM-based components are split out of `index`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The CodeMirror-based components in
ui-componentsare adding quite a bit of CSS bloat via automatic imports, and the implicit use ofnavigatorbreaks static rendering in Next.js apps.Split them out into an
editorexport, which can be used via@dagster-io/ui-components/lib/editor.It would probably be good to split the library up further, but this is at least a step in the right direction.
How I Tested These Changes
TS, lint, jest.
yarn buildfor the component library, verify that it builds correctly and that CM-based components are split out ofindex.