Move asset selection filtering to webworker #26315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salazarm
commented
Dec 6, 2024
| // Returns `false` if `filterArray` is non-empty and `valueArray` is empty (no matches possible). | ||
| // Otherwise, checks if all elements in `filterArray` have at least one corresponding match in `valueArray`. | ||
| // Uses `Array.prototype.some()` to verify if any `filterArray` element lacks a match and returns `false` in such cases. | ||
| export function doesFilterArrayMatchValueArray<T, V>( |
There was a problem hiding this comment.
Moved this to a separate file so that the webworker doesnt end up pulling React.
salazarm
commented
Dec 6, 2024
| @@ -94,23 +93,6 @@ export function useTagsForObjects<T>( | |||
| ); | |||
| } | |||
|
|
|||
| export function doesFilterArrayMatchValueArray<T, V>( | |||
There was a problem hiding this comment.
Moved this to a separate file so that the webworker doesnt end up pulling React.
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 057a43d. |
…perf-improvements
hellendag
approved these changes
Dec 6, 2024
bengotow
approved these changes
Dec 6, 2024
| @@ -225,7 +225,7 @@ export const AssetsCatalogTable = ({ | |||
|
|
|||
| const refreshState = useRefreshAtInterval({ | |||
| refresh: query, | |||
| intervalMs: FIFTEEN_SECONDS, | |||
| intervalMs: 4 * FIFTEEN_SECONDS, | |||
There was a problem hiding this comment.
This seems fairly impactful, are we ok with backing this off so much? It should already be slowing down if refresh takes a while, there's some fanciness inside this hook
There was a problem hiding this comment.
This still fires immediately if they leave tabs and come back or hit the refresh button in the top right corner.
js_modules/dagster-ui/packages/ui-core/src/asset-graph/ComputeGraphData.worker.ts
Show resolved
Hide resolved
| localStorage.setItem(DAGSTER_FLAGS_KEY, JSON.stringify(flags)); | ||
| if (broadcast) { | ||
| featureFlagsChannel.postMessage('updated'); | ||
| if (typeof localStorage !== 'undefined') { |
There was a problem hiding this comment.
Might be nice to call out that this is for the webworker case just so we don't forget 😬
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
js_modules/dagster-ui/packages/ui-core/src/asset-graph/useAssetGraphData.tsx
Outdated
Show resolved
Hide resolved
salazarm
force-pushed
the
salazarm/perf-improvements
branch
from
fd82ec0 to
16de3e2
Compare
js_modules/dagster-ui/packages/ui-core/src/util/generateObjectHash.ts
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/asset-graph/useAssetGraphData.tsx
Show resolved
Hide resolved
salazarm
force-pushed
the
salazarm/perf-improvements
branch
from
31f8f50 to
28b99af
Compare
salazarm
added a commit
that referenced
this pull request
Dec 9, 2024
Move our heavy asset selection filtering to a webworker. Added a feature flag as an escape hatch. Tested primarily with cloud-proxy with customers that have large graphs.
salazarm
added a commit
that referenced
this pull request
Dec 10, 2024
Similar to #26315, moves `buildGraphData` for the `useFullAssetGraphData` hook into a webworker. ## Test plan Tested using app-proxy and loading a big asset graph
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
## Summary & Motivation Move our heavy asset selection filtering to a webworker. Added a feature flag as an escape hatch. ## How I Tested These Changes Tested primarily with cloud-proxy with customers that have large graphs.
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
Similar to dagster-io#26315, moves `buildGraphData` for the `useFullAssetGraphData` hook into a webworker. ## Test plan Tested using app-proxy and loading a big asset graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Move our heavy asset selection filtering to a webworker. Added a feature flag as an escape hatch.
How I Tested These Changes
Tested primarily with cloud-proxy with customers that have large graphs.