Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Tick Combined PR #26354

Closed
wants to merge 10 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ import dagster_reversed from '../icon-svgs/dagster_reversed.svg';
import dagster_solid from '../icon-svgs/dagster_solid.svg';
import dagsterlabs from '../icon-svgs/dagsterlabs.svg';
import dash from '../icon-svgs/dash.svg';
import data_object from '../icon-svgs/data_object.svg';
import data_reliability from '../icon-svgs/data_reliability.svg';
import data_type from '../icon-svgs/data_type.svg';
import database from '../icon-svgs/database.svg';
Expand Down Expand Up @@ -268,6 +269,7 @@ import password from '../icon-svgs/password.svg';
import pause from '../icon-svgs/pause.svg';
import people from '../icon-svgs/people.svg';
import plots from '../icon-svgs/plots.svg';
import preview_tick from '../icon-svgs/preview_tick.svg';
import priority_1 from '../icon-svgs/priority_1.svg';
import priority_2 from '../icon-svgs/priority_2.svg';
import priority_3 from '../icon-svgs/priority_3.svg';
Expand Down Expand Up @@ -502,6 +504,7 @@ export const Icons = {
dash,
data_reliability,
data_type,
data_object,
database,
datatype_array,
datatype_bool,
Expand Down Expand Up @@ -664,6 +667,7 @@ export const Icons = {
pause,
people,
plots,
preview_tick,
priority_1,
priority_2,
priority_3,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as React from 'react';
import styled from 'styled-components';

import {Box} from './Box';
import {Colors} from './Color';
Expand Down Expand Up @@ -27,7 +28,7 @@ export const NonIdealState = ({
const singleContentElement = [title, description, action].filter(Boolean).length === 1;

return (
<Box
<NonIdealStateWrapper
flex={{gap: 20, alignItems: singleContentElement ? 'center' : 'flex-start'}}
background={Colors.backgroundLight()}
padding={24}
Expand Down Expand Up @@ -58,6 +59,8 @@ export const NonIdealState = ({
{description && <div style={{color: Colors.textDefault()}}>{description}</div>}
{action}
</Box>
</Box>
</NonIdealStateWrapper>
);
};

export const NonIdealStateWrapper = styled(Box)``;
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions js_modules/dagster-ui/packages/ui-core/client.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions js_modules/dagster-ui/packages/ui-core/src/app/Telemetry.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {gql} from '../apollo-client';

export enum TelemetryAction {
LAUNCH_RUN = 'LAUNCH_RUN',
LAUNCH_MULTIPLE_RUNS = 'LAUNCH_MULTIPLE_RUNS',
GRAPHQL_QUERY_COMPLETED = 'GRAPHQL_QUERY_COMPLETED',
}

Expand Down Expand Up @@ -38,7 +39,7 @@ const LOG_TELEMETRY_MUTATION = gql`
export async function logTelemetry(
pathPrefix: string,
action: TelemetryAction,
metadata: {[key: string]: string | null | undefined} = {},
metadata: {[key: string]: string | string[] | null | undefined} = {},
) {
const graphqlPath = `${pathPrefix || ''}/graphql`;

Expand All @@ -63,7 +64,10 @@ export async function logTelemetry(
export const useTelemetryAction = () => {
const {basePath, telemetryEnabled} = useContext(AppContext);
return useCallback(
(action: TelemetryAction, metadata: {[key: string]: string | null | undefined} = {}) => {
(
action: TelemetryAction,
metadata: {[key: string]: string | string[] | null | undefined} = {},
) => {
if (telemetryEnabled) {
logTelemetry(basePath, action, metadata);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,22 +138,30 @@ export const VirtualizedAutomationScheduleRow = forwardRef(
</Tooltip>
</RowCell>
<RowCell>
<Box flex={{direction: 'row', gap: 8, alignItems: 'flex-start'}}>
{scheduleData ? (
<Box flex={{direction: 'column', gap: 4}}>
{/* Keyed so that a new switch is always rendered, otherwise it's reused and animates on/off */}
<ScheduleSwitch key={name} repoAddress={repoAddress} schedule={scheduleData} />
{errorDisplay(
scheduleData.scheduleState.status,
scheduleData.scheduleState.runningCount,
)}
</Box>
) : (
<div style={{width: 30}} />
)}
<Link to={workspacePathFromAddress(repoAddress, `/schedules/${name}`)}>
<MiddleTruncate text={name} />
</Link>
<Box
flex={{
direction: 'row',
gap: 8,
alignItems: 'flex-start',
justifyContent: 'space-between',
}}
>
<Box flex={{grow: 1, gap: 8}}>
{scheduleData ? (
<>
<ScheduleSwitch key={name} repoAddress={repoAddress} schedule={scheduleData} />
{errorDisplay(
scheduleData.scheduleState.status,
scheduleData.scheduleState.runningCount,
)}
</>
) : (
<div style={{width: 30}} />
)}
<Link to={workspacePathFromAddress(repoAddress, `/schedules/${name}`)}>
<MiddleTruncate text={name} />
</Link>
</Box>
</Box>
</RowCell>
<RowCell>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,16 +136,25 @@ export const VirtualizedAutomationSensorRow = forwardRef(
</Tooltip>
</RowCell>
<RowCell>
<Box flex={{direction: 'row', gap: 8, alignItems: 'flex-start'}}>
{/* Keyed so that a new switch is always rendered, otherwise it's reused and animates on/off */}
{sensorData ? (
<SensorSwitch key={name} repoAddress={repoAddress} sensor={sensorData} />
) : (
<div style={{width: 30}} />
)}
<Link to={workspacePathFromAddress(repoAddress, `/sensors/${name}`)}>
<MiddleTruncate text={name} />
</Link>
<Box
flex={{
direction: 'row',
gap: 8,
alignItems: 'flex-start',
justifyContent: 'space-between',
}}
>
<Box flex={{grow: 1, gap: 8}}>
{/* Keyed so that a new switch is always rendered, otherwise it's reused and animates on/off */}
{sensorData ? (
<SensorSwitch key={name} repoAddress={repoAddress} sensor={sensorData} />
) : (
<div style={{width: 30}} />
)}
<Link to={workspacePathFromAddress(repoAddress, `/sensors/${name}`)}>
<MiddleTruncate text={name} />
</Link>
</Box>
</Box>
</RowCell>
<RowCell>
Expand Down
Loading
Loading