Manual Tick Combined PR #26365
Closed
Manual Tick Combined PR #26365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-623/relabel-test-sensorschedule-buttons-to-manual-tick Want to relabel "Test sensor" and "Test schedule" buttons to "Manual Tick" Will refactor all other instances of "Test sensor" and "Test schedule" in Dagster docs in this Linear ticket: https://linear.app/dagster-labs/issue/FE-626/update-dagster-docs-and-screenshots-for-changed-copy   ## How I Tested These Changes Tested locally
…ult modals (#25323) ## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-627/add-launch-all-frontend Add "Launch all" button to these evaluation result modals   ## How I Tested These Changes Tested locally
…25351) ## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-628/add-manual-tick-button-to-all-rows-in-automations-table Video: https://github.com/user-attachments/assets/8a7993ff-babe-4fa2-8526-a448ef1e7c2b ## How I Tested These Changes yarn lint, ts, tested locally
Linear: https://linear.app/dagster-labs/issue/FE-659/add-launch-all-backend-functionality ## Summary & Motivation Add a backend GraphQL mutation to handle launching multiple runs ## How I Tested These Changes `pytest python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py` 50 passed, 18 warnings in 206.16s (0:03:26)
## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-624/[fe]-implement-launch-all-frontend-sensor Adds the frontend for 'launch all' for manual tick sensors Video: https://github.com/user-attachments/assets/222b35c2-19c7-4bb9-a975-85f9ae56c328 ## How I Tested These Changes yarn ts, lint, make graphql
## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-654/[fe]-implement-launch-all-frontend-schedule Adds the frontend for 'launch all' for manual tick schedules Video: https://github.com/user-attachments/assets/1d3a9315-cc05-4142-8964-5e86e077403b ## How I Tested These Changes tested the launch all runs flow locally yarn lint, ts, jest, generate-graphql in ui-core
Linear: https://linear.app/dagster-labs/issue/FE-697/implement-updated-designs-initial-renames-[1n] ## Summary & Motivation Everything in Linear ticket ## How I Tested These Changes tested locally
## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-698/implement-updated-designs-sensor-cursor-page-[2n] Implement redesign for sensor cursor page  ## How I Tested These Changes Tested locally
## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-699/implement-updated-designs-sensor-result-page-[3n] Implement design for sensor result page Video: https://github.com/user-attachments/assets/053eeada-27b2-43d0-aaea-c98c9707a7c0 Timeout:  ## How I Tested These Changes jest, tested locally with all the flows in the video
## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-708/implement-updated-designs-schedule-[4n] Video: https://github.com/user-attachments/assets/0f8cea65-aef7-44f7-833e-fa111b82b703 ## How I Tested These Changes jest, yarn lint, ts, tested locally for all cases: Multiple run requests, skipped, exception ## Changelog [ui] improved ui for manual sensor/schedule evaluation
## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-713/add-jest-tests-for-sensors-and-schedules Adds jest tests for launch all ## How I Tested These Changes yarn jest, ts, lint
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 30437ed. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 30437ed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Manual Tick Evaluation Feature (has been merged into master already)
As time goes on, there will be merge conflicts because the branch is pointing to the commit before my PR stack in master (old)
Videos of feature can be seen in commit description
How I Tested These Changes
pytest, yarn lint, yarn ts, jest, tested locally