Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Clean up tool-icechunk svg #26379

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Dec 10, 2024

Summary & Motivation

Clean up the icechunk SVG to fix Storybook builds. The current SVG has a ton of extra markup we don't need.

How I Tested These Changes

yarn storybook in ui-core, view OpTags story.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hellendag hellendag marked this pull request as ready for review December 10, 2024 15:26
@hellendag
Copy link
Member Author

I guess it's not exactly the same image -- I'll see if I can do it a little differently.

Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-qu3dn0zay-elementl.vercel.app
https://dish-clean-up-icechunk-svg.core-storybook.dagster-docs.io

Built with commit dccbc25.
This pull request is being automatically deployed with vercel-action

@hellendag hellendag force-pushed the dish/clean-up-icechunk-svg branch from dccbc25 to 6197e02 Compare December 10, 2024 15:36
@hellendag hellendag merged commit 10f5643 into master Dec 10, 2024
0 of 2 checks passed
@hellendag hellendag deleted the dish/clean-up-icechunk-svg branch December 10, 2024 15:37
pskinnerthyme pushed a commit to pskinnerthyme/dagster that referenced this pull request Dec 16, 2024
## Summary & Motivation

Clean up the icechunk SVG to fix Storybook builds. The current SVG has a
ton of extra markup we don't need.

## How I Tested These Changes

`yarn storybook` in ui-core, view `OpTags` story.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants