[pyright] analyzeUnannotatedFunctions #26392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbquinlan
approved these changes
Dec 10, 2024
|
Where the light shines the roaches coming scurrying out! Hopefully this induces some crowdsourced type-tightening. |
alangenfeld
force-pushed
the
al/12-10-_pyright_analyzeunannotatedfunctions
branch
2 times, most recently
from
425102d to
d85a69e
Compare
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-p05wnlh70-elementl.vercel.app Direct link to changed pages: |
alangenfeld
force-pushed
the
al/12-10-_pyright_analyzeunannotatedfunctions
branch
from
d85a69e to
1e76ed4
Compare
alangenfeld
deleted the
al/12-10-_pyright_analyzeunannotatedfunctions
branch
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
Sibling to https://github.com/dagster-io/internal/pull/12806, enable `analyzeUnannotatedFunctions` by using a script to insert comments on newly created type errors. `examples` is exempted from this as the type suppresion comments negatively impact using terse code snippets in docs etc. ## How I Tested These Changes make pyright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling to https://github.com/dagster-io/internal/pull/12806, enable
analyzeUnannotatedFunctionsby using a script to insert comments on newly created type errors.examplesis exempted from this as the type suppresion comments negatively impact using terse code snippets in docs etc.How I Tested These Changes
make pyright