[dagster-fivetran] Implement FivetranEventIterator #26396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
maximearmstrong
force-pushed
the
maxime/implement-fivetran-event-iterator
branch
from
4c1fef8 to
49c4665
Compare
This was referenced Dec 10, 2024
maximearmstrong
force-pushed
the
maxime/implement-fivetran-event-iterator
branch
from
49c4665 to
969b992
Compare
dpeng817
reviewed
Dec 11, 2024
| T = TypeVar("T", bound=FivetranEventType) | ||
|
|
||
|
|
||
| class FivetranEventIterator(Generic[T], abc.Iterator): |
There was a problem hiding this comment.
suprised we're using abc.Iterator and not typing.Iterator?
There was a problem hiding this comment.
wait why is this an abstract base class? We're instantiating it right?
There was a problem hiding this comment.
That's a good call. I replicated what we already have for other integrations - DbtEventIterator, DltEventIterator and SlingEventIterator are all subclassing abc.Iterator - but I agree that subclassing typing.Iterator makes much more sense. Will fix here and open PRs to update the other integrations.
There was a problem hiding this comment.
Updated in 0582d6f
dpeng817
previously requested changes
Dec 11, 2024
maximearmstrong
force-pushed
the
maxime/implement-fivetran-event-iterator
branch
from
969b992 to
0582d6f
Compare
maximearmstrong
added a commit
that referenced
this pull request
Dec 12, 2024
## Summary & Motivation Subclass `typing.Iterator` instead of `abc.Iterator` in `DbtEventIterator`. This is motivated by [this discussion](#26396 (comment)). ## How I Tested These Changes Same tests with BK
dpeng817
reviewed
Dec 12, 2024
| T = TypeVar("T", bound=FivetranEventType) | ||
|
|
||
|
|
||
| class FivetranEventIterator(Generic[T], Iterator): |
There was a problem hiding this comment.
Should be Iterator[T] as well right
maximearmstrong
force-pushed
the
maxime/implement-fivetran-event-iterator
branch
from
0582d6f to
d5e4a25
Compare
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…o#26424) ## Summary & Motivation Subclass `typing.Iterator` instead of `abc.Iterator` in `DbtEventIterator`. This is motivated by [this discussion](dagster-io#26396 (comment)). ## How I Tested These Changes Same tests with BK
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
## Summary & Motivation This PR adds at basic `FivetranEventIterator` that wraps materializations yielded by `FivetranWorkspace.sync_and_poll`. This `FivetranEventIterator` will be used to implement fetch_column_metadata in the next stacked PR. ## How I Tested These Changes Existing tests with BK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR adds at basic
FivetranEventIteratorthat wraps materializations yielded byFivetranWorkspace.sync_and_poll. ThisFivetranEventIteratorwill be used to implement fetch_column_metadata in the next stacked PR.How I Tested These Changes
Existing tests with BK