[du] add backoff for duckdb connections #26408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmpadden
reviewed
Dec 11, 2024
| @@ -111,6 +125,8 @@ To refactor `taxi_trips` to use the `database` resource, we had to: | |||
| conn.execute(query) | |||
| ``` | |||
|
|
|||
| Notice that we no longer need to use the `backoff` function. The Dagster `DuckDBResource` handles this functionality for us. | |||
There was a problem hiding this comment.
Nice, thanks for calling this out.
cmpadden
approved these changes
Dec 11, 2024
neverett
approved these changes
Dec 12, 2024
docs/dagster-university/pages/dagster-essentials/lesson-4/loading-data-into-a-database.md
Outdated
Show resolved
Hide resolved
| @@ -111,6 +125,8 @@ To refactor `taxi_trips` to use the `database` resource, we had to: | |||
| conn.execute(query) | |||
| ``` | |||
|
|
|||
| Notice that we no longer need to use the `backoff` function. The Dagster `DuckDBResource` handles this functionality for us. | |||
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
## Summary & Motivation Update code snippets for sections 4 and 6 to wrap DuckDB connection in backoff to prevent race conditions when materializing all assets (Not an issue after these assets switch to using resources). ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Update code snippets for sections 4 and 6 to wrap DuckDB connection in backoff to prevent race conditions when materializing all assets (Not an issue after these assets switch to using resources).
How I Tested These Changes
Changelog