[Selection syntax autocomplete](Refactor) input component to be generalized. #26410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 8b45cbb. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
js_modules/dagster-ui/packages/ui-core/src/selection/SelectionAutoCompleteInput.tsx
Outdated
Show resolved
Hide resolved
salazarm
force-pushed
the
salazarm/refactor-selection-auto-complete
branch
from
f13479f to
8b45cbb
Compare
salazarm
changed the title
hellendag
approved these changes
Dec 13, 2024
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…alized. (dagster-io#26410) ## Summary & Motivation Last remaining piece of the generalized autocomplete work is to generalize the input component itself. The generalized SelectionAutoCompleteInput component will be used by the Run gantt chart selection input, the op selection input and the asset selection input. Note this PR is just a refactor. No new logic was added. ## How I Tested These Changes Existing jest tests + manually tested the asset selection filtering input and made sure it still works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Last remaining piece of the generalized autocomplete work is to generalize the input component itself.
The generalized SelectionAutoCompleteInput component will be used by the Run gantt chart selection input, the op selection input and the asset selection input.
Note this PR is just a refactor. No new logic was added.
How I Tested These Changes
Existing jest tests + manually tested the asset selection filtering input and made sure it still works.