[du] consistency issues #26416
[du] consistency issues #26416
Conversation
|
Deploy preview for dagster-university ready! ✅ Preview Built with commit 2a0e509. |
| @@ -9,11 +9,12 @@ lesson: '2' | |||
| To install Dagster, you’ll need: | |||
|
|
|||
| - **To install Python**. Dagster supports Python 3.9 through 3.12. | |||
| - **A package manager like pip or poetry**. If you need to install a package manager, refer to the following installation guides: | |||
| - **A package manager like pip, poetry or uv**. If you need to install a package manager, refer to the following installation guides: | |||
There was a problem hiding this comment.
Adding in uv as an option since we use that other places in the repo and was what I used to complete the class
There was a problem hiding this comment.
I would capitalize "poetry" here for consistency and add a comma after it.
| @@ -10,8 +10,8 @@ An asset is an object in persistent storage that captures some understanding of | |||
|
|
|||
| - **A database table or view**, such as those in a Google BigQuery data warehouse | |||
| - **A file**, such as a file in your local machine or blob storage like Amazon S3 | |||
| - **A machine learning model** | |||
| - **An asset from an integration,** like a dbt model or a Fivetran connector | |||
| - **A machine learning model**, such as TensorFlow or PyTorch | |||
There was a problem hiding this comment.
Adding in example since it was the only bullet point without one
| @@ -30,7 +30,7 @@ The asset you built should look similar to the following code. Click **View answ | |||
| deps=["taxi_zones_file"] | |||
| ) | |||
| def taxi_zones() -> None: | |||
| sql_query = f""" | |||
| query = f""" | |||
There was a problem hiding this comment.
Standardizing around query as the variable name since that is what the dagster university repo uses in functions
| > import duckdb | ||
| > conn = duckdb.connect(database="data/staging/data.duckdb") # assumes you're writing to the same destination as specified in .env.example | ||
| > conn.execute("select count(*) from trips").fetchall() | ||
| import duckdb |
There was a problem hiding this comment.
Removing > for consistency and so it is easier to copy and run in Python REPL
| @@ -63,7 +63,7 @@ To add the partition to the asset: | |||
| @asset( | |||
| partitions_def=monthly_partition | |||
| ) | |||
| def taxi_trips_file(context) -> None: | |||
| def taxi_trips_file(context: AssetExecutionContext) -> None: | |||
There was a problem hiding this comment.
First example snippet uses type annotation. Including for consistency
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-8fuc6jrnl-elementl.vercel.app Direct link to changed pages:
|
There was a problem hiding this comment.
Nice, good attention to detail!
Out of curiosity, did you notice any discrepancies in screenshots when you completed the course? Maintaining screenshots has been quite a pain to maintain since you essentially need to be at the specific step in the course to capture it.
Yeah. A lot of the screenshots need updating (specifically the tabs around automation). I wrote up a ticket for myself to update those when we update content to the latest version |
| @@ -9,11 +9,12 @@ lesson: '2' | |||
| To install Dagster, you’ll need: | |||
|
|
|||
| - **To install Python**. Dagster supports Python 3.9 through 3.12. | |||
| - **A package manager like pip or poetry**. If you need to install a package manager, refer to the following installation guides: | |||
| - **A package manager like pip, poetry or uv**. If you need to install a package manager, refer to the following installation guides: | |||
There was a problem hiding this comment.
I would capitalize "poetry" here for consistency and add a comma after it.
## Summary & Motivation Minor consistency issues from working through Dagster University ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
Summary & Motivation
Minor consistency issues from working through Dagster University
How I Tested These Changes
Changelog