Implement AntlrOpSelectionVisitor on frontend #26467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 7fda38d. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
js_modules/dagster-ui/packages/ui-core/src/op-selection/__tests__/AntlrOpSelection.test.ts
Outdated
Show resolved
Hide resolved
salazarm
approved these changes
Dec 13, 2024
briantu
force-pushed
the
briantu/implement-op-selection-visitor
branch
from
04c2c30 to
5b32f61
Compare
briantu
changed the base branch from
briantu/add-syntax-op-selection-frontend
to
graphite-base/26467
briantu
force-pushed
the
briantu/implement-op-selection-visitor
branch
from
5b32f61 to
7fda38d
Compare
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
## Summary & Motivation Implement visitor pattern for op selection syntax. ## How I Tested These Changes `AntlrOpSelection.test.ts`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Implement visitor pattern for op selection syntax.
How I Tested These Changes
AntlrOpSelection.test.ts