Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] add sorting order to show more assets and asset checks #26474

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

dliu27
Copy link
Contributor

@dliu27 dliu27 commented Dec 13, 2024

Summary & Motivation

Linear: https://linear.app/dagster-labs/issue/FE-692/implement-ordering-for-asset-checks-in-run-view

How I Tested These Changes

Tested locally

Copy link

github-actions bot commented Dec 13, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-bzrsew85f-elementl.vercel.app
https://dliu27-show-more-asset-ordering.core-storybook.dagster-docs.io

Built with commit 5403f3c.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just pass the items already sorted to useShowMoreDialog

@dliu27 dliu27 requested a review from salazarm December 16, 2024 16:28
Copy link
Collaborator

@bengotow bengotow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@dliu27 dliu27 merged commit d0ea5ad into master Dec 17, 2024
1 of 2 checks passed
@dliu27 dliu27 deleted the dliu27/show-more-asset-ordering branch December 17, 2024 22:22
danielgafni pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants