-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] add sorting order to show more assets and asset checks #26474
Conversation
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 5403f3c. |
js_modules/dagster-ui/packages/ui-core/src/runs/AssetTagCollections.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/runs/AssetTagCollections.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just pass the items already sorted to useShowMoreDialog
js_modules/dagster-ui/packages/ui-core/src/runs/AssetTagCollections.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/runs/AssetTagCollections.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/runs/AssetTagCollections.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
js_modules/dagster-ui/packages/ui-core/src/runs/AssetTagCollections.tsx
Outdated
Show resolved
Hide resolved
## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-692/implement-ordering-for-asset-checks-in-run-view ## How I Tested These Changes Tested locally
Summary & Motivation
Linear: https://linear.app/dagster-labs/issue/FE-692/implement-ordering-for-asset-checks-in-run-view
How I Tested These Changes
Tested locally