Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-fivetran][docs] Migrate Fivetran docs to new doc site #26485

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Dec 13, 2024

Summary & Motivation

Copy and migrate new Fivetran docs to new site, see original PR #26026

Removing docs-to-migrate tag from the original PR

How I Tested These Changes

BK.

Copy link
Contributor Author

maximearmstrong commented Dec 13, 2024

Copy link

github-actions bot commented Dec 13, 2024

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-7r9bnoto1-elementl.vercel.app

Direct link to changed pages:


## Represent Fivetran assets in the asset graph

To load Fivetran assets into the Dagster asset graph, you must first construct a <PyObject module="dagster_fivetran" object="FivetranWorkspace" /> resource, which allows Dagster to communicate with your Fivetran workspace. You'll need to supply your account ID, API key and API secret. See [Getting Started](https://fivetran.com/docs/rest-api/getting-started) in the Fivetran REST API documentation for more information on how to create your API key and API secret.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PyObject components are creating an undefined. Is that specific to Fivetran or more broadly an issue with the new docs? If more broad we can merge and make a follow-up ticket to fix this.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the same PyObject not implemented yet error in the I/O manager guide that is already in the docs

In the I/O manager guide:
Screenshot 2024-12-16 at 2 42 04 PM

In the Fivetran docs:
Screenshot 2024-12-16 at 2 43 17 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree with @cmpadden -- let's merge this, and I'll make a ticket to follow up on PyObject implementation in new docs.

@maximearmstrong maximearmstrong force-pushed the maxime/migrate-fivetran-docs branch from e61d3b4 to d82cf47 Compare December 16, 2024 19:47
@maximearmstrong maximearmstrong merged commit d32aab7 into master Dec 16, 2024
3 checks passed
@maximearmstrong maximearmstrong deleted the maxime/migrate-fivetran-docs branch December 16, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants