Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-embedded-elt] Expose dlt and sling extras #26497

Closed
wants to merge 1 commit into from

Conversation

deepyaman
Copy link
Contributor

Summary & Motivation

As a user, I don't unnecessarily want to install Sling if I'm only using dlt and vice versa.

How I Tested These Changes

Changelog

dlt and Sling are now extra requirements of the dagster-embedded-elt package; to include them, install dagster-embedded-elt[dlt] or dagster-embedded-elt[sling], respectively.

Copy link

github-actions bot commented Dec 13, 2024

@deepyaman deepyaman force-pushed the deepyaman/build/embedded-elt-extras branch from ae1d5f3 to 586f9a8 Compare December 14, 2024 00:01
Copy link

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-63xuyaycb-elementl.vercel.app
https://deepyaman-build-embedded-elt-extras.dagster.dagster-docs.io

Direct link to changed pages:

@deepyaman deepyaman marked this pull request as ready for review December 14, 2024 00:11
@deepyaman deepyaman requested a review from neverett as a code owner December 14, 2024 00:11
Copy link
Contributor

@cmpadden @PedramNavid do either of you recall why we didn't do it this way to begin with? I remember there was some discussion about having embedded-elt be its own package vs. having dagster-sling and dagster-dlt, wondering if there's some context missing there

Copy link
Contributor

Can’t think of any reason why we wouldn’t do this. Will this be a breaking change?

Copy link
Contributor

@OwenKephart OwenKephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline: this would unfortunately be a breaking change

@zilto
Copy link
Contributor

zilto commented Dec 16, 2024

As a user, I was about to open a issue for the same reason.

Inconvenience

  • The pypi target dagster-embbed-elt doesn't follow the integration convention and I had to go through the docs to find it ("embbed elt" could be obscure terms for users)
  • I don't want to install sling or depend on it. The Python install seems small, but it seems to require a binary that's about 50Mb, which might matter on AWS lambdas and such.
  • The Python imports dagster_embedded_elt may be more obvious with dagster_sling and dagster_dlt

Potential solution

There seems to be two-fold for backwards compatibility:

  • pypi: create pypi targets dagster-dlt and dagster-sling while keeping dagster-embbed-elt
  • python modules: Could have a dagster-dlt namespace that imports dagster_embbed_elt.dlt

@OwenKephart
Copy link
Contributor

Hi @zilto ! Thanks for weighing in here -- we're currently planning on segmenting these libraries out essentially as you describe, although we'll likely just port the code for each integration into the new libraries and keep dagster-embedded-elt as a thin backcompat layer with dependencies on dagster-sling and dagster-dlt (rather than vice-versa)

@deepyaman
Copy link
Contributor Author

Closing this issue and creating #26523 to track the effort to split out these libraries.

@deepyaman deepyaman closed this Dec 16, 2024
@deepyaman deepyaman deleted the deepyaman/build/embedded-elt-extras branch December 16, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants