Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-beta] migrate - managing compute logs and error messages #26500

Merged
merged 3 commits into from
Dec 19, 2024
Merged

[docs-beta] migrate - managing compute logs and error messages #26500

merged 3 commits into from
Dec 19, 2024
+103 −1

Conversation

cmpadden
Copy link
Contributor

@cmpadden cmpadden commented Dec 14, 2024 •
edited
Loading

Summary & Motivation

Broken links marked /todo:

  - Broken link on source page path = /dagster-plus/deployment/management/managing-compute-logs-and-error-messages:
     -> linking to /concepts/logging#log-types
     -> linking to /dagster-plus/deployment/agents/customizing-configuration
     -> linking to /deployment/dagster-instance#compute-log-storage

How I Tested These Changes

Changelog

NOCHANGELOG

@cmpadden cmpadden added the area:docs-revamp Related to the revamp of the docs label Dec 16, 2024
@cmpadden cmpadden marked this pull request as ready for review December 19, 2024 15:47
@cmpadden cmpadden requested a review from neverett December 19, 2024 15:47
@github-actions GitHub Actions
Copy link

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-cymu22b7u-elementl.vercel.app

Direct link to changed pages:

C00ldudeNoonan
C00ldudeNoonan approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@C00ldudeNoonan C00ldudeNoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@C00ldudeNoonan C00ldudeNoonan merged commit 1cb5882 into master Dec 19, 2024
1 of 3 checks passed
@C00ldudeNoonan C00ldudeNoonan deleted the colton/doc-610-managing-compute-logs-and-error-messages branch December 19, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dehume dehume dehume left review comments

@C00ldudeNoonan C00ldudeNoonan C00ldudeNoonan approved these changes

@neverett neverett Awaiting requested review from neverett neverett is a code owner

Assignees
No one assigned
Labels
area:docs-revamp Related to the revamp of the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmpadden @neverett @dehume @C00ldudeNoonan