[ui] add pipelineName in consideration with launching all runs #26525
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salazarm
approved these changes
Dec 16, 2024
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit dc51f0f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Linear: https://linear.app/dagster-labs/issue/AD-728/sensor-triggered-asset-materialization-error
Since useLaunchMultipleWithTelemetry is based off of useLaunchWithTelemetry, here is the relevant code in useLaunchWithTelemetry:
dagster/js_modules/dagster-ui/packages/ui-core/src/launchpad/useLaunchWithTelemetry.oss.ts
Lines 29 to 31 in 279d44a
How I Tested These Changes
Tested locally