[ui] Limit the amount of asset info required for evaluation list #26571
+37
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 2e462bd. |
hellendag
force-pushed
the
dish/evaluation-query-less
branch
from
d86966a to
e449a21
Compare
salazarm
approved these changes
Dec 19, 2024
|
Yeah, sorry not to have been clearer about that -- it'll be used in a separate stack of PRs that are tangled up with a backend change that is currently still in draft mode. I ran into this while working on that stack and decided to go ahead and fix it now. |
hellendag
force-pushed
the
dish/evaluation-query-less
branch
from
e449a21 to
2e462bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We don't need so much fragment data for the evaluation list, so let's require less so that consumers don't need to overquery.
How I Tested These Changes
TS, lint, storybook.