Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] fix searching for multi partitions #26580

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

dliu27
Copy link
Contributor

@dliu27 dliu27 commented Dec 18, 2024

Summary & Motivation

Linear: https://linear.app/dagster-labs/issue/FE-735/bug-partition-filter-in-ui-for-multipartitionsdefinition-f

Make searchValues state an array of searchValue

How I Tested These Changes

Tested with multi_partitions asset with app-proxy to dogfood-test-1

Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Can you update the tests.

Copy link

github-actions bot commented Dec 18, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-ntz0aakwg-elementl.vercel.app
https://dliu27-fix-sorting-for-multi-partitions.core-storybook.dagster-docs.io

Built with commit 698de97.
This pull request is being automatically deployed with vercel-action

@dliu27 dliu27 merged commit b6b004b into master Dec 20, 2024
1 of 2 checks passed
@dliu27 dliu27 deleted the dliu27/fix-sorting-for-multi-partitions branch December 20, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants