Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-fivetran] Move DagsterFivetranTranslator metadata to Fivetran specs loader #26587

Merged
merged 1 commit into from
Dec 20, 2024
Merged

[dagster-fivetran] Move DagsterFivetranTranslator metadata to Fivetran specs loader #26587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions python_modules/libraries/dagster-fivetran/dagster_fivetran/asset_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

from dagster_fivetran.resources import FivetranWorkspace
from dagster_fivetran.translator import DagsterFivetranTranslator, FivetranMetadataSet
from dagster_fivetran.utils import DAGSTER_FIVETRAN_TRANSLATOR_METADATA_KEY


@experimental
Expand Down Expand Up @@ -109,9 +108,7 @@ def fivetran_connector_assets(context: dg.AssetExecutionContext, fivetran: Fivet
group_name=group_name,
can_subset=True,
specs=[
spec.merge_attributes(
metadata={DAGSTER_FIVETRAN_TRANSLATOR_METADATA_KEY: dagster_fivetran_translator}
)
spec
for spec in workspace.load_asset_specs(
dagster_fivetran_translator=dagster_fivetran_translator
)
Expand Down
24 changes: 16 additions & 8 deletions python_modules/libraries/dagster-fivetran/dagster_fivetran/resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
)
from dagster_fivetran.types import FivetranOutput
from dagster_fivetran.utils import (
DAGSTER_FIVETRAN_TRANSLATOR_METADATA_KEY,
get_fivetran_connector_table_name,
get_fivetran_connector_url,
get_fivetran_logs_url,
Expand Down Expand Up @@ -1100,16 +1101,23 @@ def load_fivetran_asset_specs(
fivetran_specs = load_fivetran_asset_specs(fivetran_workspace)
defs = dg.Definitions(assets=[*fivetran_specs], resources={"fivetran": fivetran_workspace}
"""
dagster_fivetran_translator = dagster_fivetran_translator or DagsterFivetranTranslator()

with workspace.process_config_and_initialize_cm() as initialized_workspace:
return check.is_list(
FivetranWorkspaceDefsLoader(
workspace=initialized_workspace,
translator=dagster_fivetran_translator or DagsterFivetranTranslator(),
return [
spec.merge_attributes(
metadata={DAGSTER_FIVETRAN_TRANSLATOR_METADATA_KEY: dagster_fivetran_translator}
)
.build_defs()
.assets,
AssetSpec,
)
for spec in check.is_list(
FivetranWorkspaceDefsLoader(
workspace=initialized_workspace,
translator=dagster_fivetran_translator,
)
.build_defs()
.assets,
AssetSpec,
)
]


@record
Expand Down