Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add docs for reworked Airbyte Cloud API #26595

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Dec 19, 2024

Summary & Motivation

As title.

How I Tested These Changes

Docs preview

@maximearmstrong maximearmstrong self-assigned this Dec 19, 2024
@maximearmstrong maximearmstrong marked this pull request as ready for review December 19, 2024 15:53
@neverett neverett added the docs-to-migrate Docs to migrate to new docs site label Dec 19, 2024
Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small copyediting suggestions, otherwise LGTM

- Familiarity with asset definitions and the Dagster asset graph
- Familiarity with Dagster resources
- Familiarity with Airbyte Cloud concepts, like connections and connection tables
- A Airbyte Cloud workspace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- A Airbyte Cloud workspace
- An Airbyte Cloud workspace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in ba8ac3a

- Familiarity with Dagster resources
- Familiarity with Airbyte Cloud concepts, like connections and connection tables
- A Airbyte Cloud workspace
- A Airbyte Cloud client ID and client secret. For more information, see [Configuring API Access](https://docs.airbyte.com/using-airbyte/configuring-api-access) in the Airbyte Cloud REST API documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- A Airbyte Cloud client ID and client secret. For more information, see [Configuring API Access](https://docs.airbyte.com/using-airbyte/configuring-api-access) in the Airbyte Cloud REST API documentation.
- An Airbyte Cloud client ID and client secret. For more information, see [Configuring API Access](https://docs.airbyte.com/using-airbyte/configuring-api-access) in the Airbyte Cloud REST API documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in ba8ac3a

@maximearmstrong maximearmstrong force-pushed the maxime/move-airbyte-docs-to-legacy-page branch from 98fd3ad to 1e7c2c9 Compare December 26, 2024 15:30
@maximearmstrong maximearmstrong force-pushed the maxime/add-new-airbyte-cloud-docs branch from ba8ac3a to 997ba65 Compare December 26, 2024 15:30
@maximearmstrong maximearmstrong force-pushed the maxime/move-airbyte-docs-to-legacy-page branch from 1e7c2c9 to b36741a Compare December 26, 2024 15:45
@maximearmstrong maximearmstrong force-pushed the maxime/add-new-airbyte-cloud-docs branch from 997ba65 to 655a273 Compare December 26, 2024 15:45
@maximearmstrong maximearmstrong force-pushed the maxime/move-airbyte-docs-to-legacy-page branch from b36741a to 76c1ead Compare December 26, 2024 16:09
@maximearmstrong maximearmstrong force-pushed the maxime/add-new-airbyte-cloud-docs branch from 655a273 to 5b1ee2f Compare December 26, 2024 16:09
@maximearmstrong maximearmstrong force-pushed the maxime/move-airbyte-docs-to-legacy-page branch from 76c1ead to e590828 Compare December 26, 2024 16:44
@maximearmstrong maximearmstrong force-pushed the maxime/add-new-airbyte-cloud-docs branch from 5b1ee2f to a3c465e Compare December 26, 2024 16:44
@maximearmstrong maximearmstrong force-pushed the maxime/move-airbyte-docs-to-legacy-page branch from e590828 to 400c10a Compare December 26, 2024 16:57
@maximearmstrong maximearmstrong force-pushed the maxime/add-new-airbyte-cloud-docs branch from a3c465e to 0262dca Compare December 26, 2024 16:58
@maximearmstrong maximearmstrong force-pushed the maxime/move-airbyte-docs-to-legacy-page branch from 400c10a to 1e42ef2 Compare December 26, 2024 17:22
@maximearmstrong maximearmstrong force-pushed the maxime/add-new-airbyte-cloud-docs branch from 0262dca to 6778a19 Compare December 26, 2024 17:22
@maximearmstrong maximearmstrong force-pushed the maxime/move-airbyte-docs-to-legacy-page branch from 1e42ef2 to a86e149 Compare December 26, 2024 17:39
@maximearmstrong maximearmstrong force-pushed the maxime/add-new-airbyte-cloud-docs branch from 6778a19 to 922d17d Compare December 26, 2024 17:39
@maximearmstrong maximearmstrong force-pushed the maxime/move-airbyte-docs-to-legacy-page branch from a86e149 to c1aba5a Compare December 26, 2024 18:21
@maximearmstrong maximearmstrong force-pushed the maxime/add-new-airbyte-cloud-docs branch from 922d17d to 0c7e09c Compare December 26, 2024 18:21
Base automatically changed from maxime/move-airbyte-docs-to-legacy-page to master December 26, 2024 18:48
@maximearmstrong maximearmstrong force-pushed the maxime/add-new-airbyte-cloud-docs branch from 0c7e09c to c175021 Compare December 26, 2024 18:49
@maximearmstrong maximearmstrong merged commit 78c3c38 into master Dec 26, 2024
2 checks passed
@maximearmstrong maximearmstrong deleted the maxime/add-new-airbyte-cloud-docs branch December 26, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-to-migrate Docs to migrate to new docs site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants