Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new selection syntax in Run GanttChart. #26632

Merged
merged 15 commits into from
Dec 23, 2024

Conversation

salazarm
Copy link
Contributor

Summary & Motivation

Adds support for the new selection syntax in the Gantt chart.

How I Tested These Changes

Tested:

  1. Retrying runs using the selection syntax to select the steps.
  2. Selecting / Unselecting multiple steps by shift clicking on steps.
  3. Using status and name filters.
  4. Making sure the logs are filtered to the correct steps matching the selection.
Screenshot 2024-12-20 at 10 30 52 AM Screenshot 2024-12-20 at 10 30 46 AM Screenshot 2024-12-20 at 10 30 40 AM Screenshot 2024-12-20 at 10 30 18 AM Screenshot 2024-12-20 at 10 30 00 AM

Copy link

github-actions bot commented Dec 20, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-1fkwc4zfe-elementl.vercel.app
https://salazarm-gantt-chart-selection.core-storybook.dagster-docs.io

Built with commit 655eaf4.
This pull request is being automatically deployed with vercel-action

Base automatically changed from salazarm/weakMapMemoize to master December 20, 2024 22:21
@salazarm salazarm merged commit b96403d into master Dec 23, 2024
1 of 2 checks passed
@salazarm salazarm deleted the salazarm/gantt-chart-selection branch December 23, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants