Revert "[ui] Upgrade styled-components to v6 (#26280)" #26639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salazarm
approved these changes
Dec 20, 2024
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit f989e2e. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit f989e2e. |
hellendag
force-pushed
the
dish/revert-sc-6
branch
2 times, most recently
from
ce0a46b to
eb14788
Compare
This reverts commit 1a2a067. [INTERNAL_BRANCH=dish/plus-revert-sc-6]
hellendag
force-pushed
the
dish/revert-sc-6
branch
from
eb14788 to
f989e2e
Compare
gibsondan
pushed a commit
that referenced
this pull request
Dec 20, 2024
## Summary & Motivation We've seen reports of styles failing to be applied in the app in certain (very difficult to reproduce) conditions, and the recent styled-components upgrade seems like a possible culprit. Revert to try to resolve the issue. ## How I Tested These Changes TS/lint/jest. Load the app, verify that everything renders as expected. ## Changelog [ui] FIx an issue where the app sometimes loads with styles missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We've seen reports of styles failing to be applied in the app in certain (very difficult to reproduce) conditions, and the recent styled-components upgrade seems like a possible culprit. Revert to try to resolve the issue.
How I Tested These Changes
TS/lint/jest. Load the app, verify that everything renders as expected.
Changelog
[ui] FIx an issue where the app sometimes loads with styles missing.