[SelectionAutoCompleteInput] Fix clicking on auto-complete result. #26844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 4f07f14. |
salazarm
commented
Jan 6, 2025
Comment on lines
209
to
212
| if (document.body.querySelector('.CodeMirror-hints')) { | ||
| // Hints already visible | ||
| return; | ||
| } |
There was a problem hiding this comment.
I could future proof this a bit by specifying a custom container for the hints... in case we ever render multiple of these inputs on the same page and specify closeOnUnfocuse: false
There was a problem hiding this comment.
Hm, yeah. I could see there being more than one of these on a page.
hellendag
approved these changes
Jan 6, 2025
Comment on lines
209
to
212
| if (document.body.querySelector('.CodeMirror-hints')) { | ||
| // Hints already visible | ||
| return; | ||
| } |
There was a problem hiding this comment.
Hm, yeah. I could see there being more than one of these on a page.
…fix-clicking-result
…fix-clicking-result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Clicking on a result was broken because our focus handler would cause us to call
showHintagain which would cause the completion to be thrown out. To fix this guard against calling showHint again if hints are already visible.