Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Lint cleanup #26852

Merged
merged 1 commit into from
Jan 6, 2025
Merged

[ui] Lint cleanup #26852

merged 1 commit into from
Jan 6, 2025

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Jan 6, 2025

Summary & Motivation

I've noticed these lint warnings recently. Just tidying up.

How I Tested These Changes

yarn lint, no wranings remain.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hellendag hellendag requested review from bengotow and salazarm January 6, 2025 18:27
@hellendag hellendag marked this pull request as ready for review January 6, 2025 18:27
Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change these lints from warning to error?

Copy link

github-actions bot commented Jan 6, 2025

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-lpgvntnrh-elementl.vercel.app
https://dish-lint-cleanup.core-storybook.dagster-docs.io

Built with commit a686a80.
This pull request is being automatically deployed with vercel-action

Copy link
Member Author

May as well, yeah.

Copy link
Member Author

hellendag commented Jan 6, 2025

Merge activity

  • Jan 6, 12:33 PM CST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 6, 12:33 PM CST: A user merged this pull request with Graphite.

@hellendag hellendag merged commit 1dc54ca into master Jan 6, 2025
1 of 2 checks passed
@hellendag hellendag deleted the dish/lint-cleanup branch January 6, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants