Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compiled SQL for dbt models to the event logs #63

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

izzye84
Copy link
Collaborator

@izzye84 izzye84 commented Mar 7, 2024

Add compiled SQL for dbt models to the event logs

Copy link

github-actions bot commented Mar 7, 2024

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
demo_assets View in Cloud Mar 09, 2024 at 05:50 AM (UTC)
snowflake_insights View in Cloud Mar 09, 2024 at 05:50 AM (UTC)
basics View in Cloud Mar 09, 2024 at 05:50 AM (UTC)
data-eng-pipeline View in Cloud Mar 09, 2024 at 05:50 AM (UTC)
batch_enrichment View in Cloud Mar 09, 2024 at 05:50 AM (UTC)

@izzye84 izzye84 requested review from slopp and cnolanminich March 7, 2024 21:01
Copy link
Contributor

@slopp slopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

not related to this PR, but would you be willing to modify the dbt slim ci op to add these lines:

# This op will be used to run slim CI
@op(
    out={}
)

The out={} will prevent that slim ci job from erroring each time. I tested it in the open demo PR, but realize I never merged it to master.

@cnolanminich
Copy link
Contributor

@slopp already approved but just came here to say that this is awesome!

@izzye84 izzye84 merged commit 4f0c7c8 into master Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants