Clean up build #64
Merged
Clean up build #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to imp vs. importlib changes needed
|
Your pull request is automatically being deployed to Dagster Cloud.
|
slopp
reviewed
Mar 8, 2024
| @@ -6,9 +6,6 @@ clean: | |||
| rm -rf ~/.dagster_home; mkdir ~/.dagster_home; cp dagster.yaml ~/.dagster_home/dagster.yaml | |||
|
|
|||
| manifest: | |||
There was a problem hiding this comment.
This command is run in the context of the GHA runner in order to build the manifest, so these installs are necessary.
There was a problem hiding this comment.
yeah I realized that too late -- that said, I'd prefer to put the commands in the GHA vs. in the make file (since you might run make manifest in the context of local dev, in which case we don't need the pip installs (handled via the setup.py)
izzye84
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR does a bunch of small things to the build process for the hooli project:
uvas the package installer (should ~halve the build time)setup.pyto <3.12, in part because there are issues loading Dagster on 3.12 that I didn't investigate