Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add column-level-lineage to hooli #68

Merged
merged 8 commits into from
Apr 8, 2024
Merged

Conversation

cnolanminich
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Mar 22, 2024

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
batch_enrichment View in Cloud Apr 05, 2024 at 05:38 PM (UTC)
data-eng-pipeline View in Cloud Apr 05, 2024 at 05:38 PM (UTC)
snowflake_insights View in Cloud Apr 05, 2024 at 05:38 PM (UTC)
basics View in Cloud Apr 05, 2024 at 05:38 PM (UTC)
demo_assets View in Cloud Apr 05, 2024 at 05:38 PM (UTC)

@cnolanminich cnolanminich changed the title dummy change add column-level-lineage to hooli Mar 30, 2024
@cnolanminich cnolanminich requested review from slopp and izzye84 April 4, 2024 20:16
@slopp
Copy link
Contributor

slopp commented Apr 4, 2024

@cnolanminich
Copy link
Contributor Author

@slopp I haven't tracked down why, but locally on duckdb getting the warning:

An error occurred while building column lineage metadata for the dbt resource models/CLEANED/users_cleaned.sql. Lineage metadata will not be included in the event.
Exception: No expression was parsed from 'TIMESTAMP_NS'

in snowflake on the branch deployment:

An error occurred while building column lineage metadata for the dbt resource models/ANALYTICS/order_stats.sql. Lineage metadata will not be included in the event.

Exception: No expression was parsed from 'TIMESTAMP_NTZ'

Initially I thought it was a dbt_date (dbt package imported by dbt_expectations) issue because I saw references to timestamp_ntz in macros in the manifest file, but I removed the package, deleted all the manifests, and re-built everything and it's still giving the same messages

@cnolanminich
Copy link
Contributor Author

things look good after switching to use get_env() to switch the dbt run target -- thanks @rexledesma for ID'ing the root cause 🎉

image

Copy link
Contributor

@slopp slopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🥳

@cnolanminich cnolanminich merged commit 2705002 into master Apr 8, 2024
1 check passed
@cnolanminich cnolanminich deleted the update-to-newest-python branch April 8, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants