Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-waku): --template option #1238

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

rmarscher
Copy link
Contributor

Also related to #1208. I didn't realize template was different from example.

Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Feb 17, 2025 8:30am

Copy link

codesandbox-ci bot commented Feb 17, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi
Copy link
Owner

dai-shi commented Feb 17, 2025

My intention was to use --example for template too. You can specify the example with the tag.

@dai-shi
Copy link
Owner

dai-shi commented Feb 17, 2025

Hm, but yeah, this makes sense for your use case.

Comment on lines 73 to 75
template: {
type: 'string',
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the usage displayUsage.

Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good.

@dai-shi dai-shi merged commit 3c95bf5 into dai-shi:main Feb 17, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants