Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scenario: Escape #2284

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Update scenario: Escape #2284

merged 1 commit into from
Jan 17, 2025

Conversation

Xansta
Copy link
Contributor

@Xansta Xansta commented Jan 16, 2025

This pull request addresses items in issue #2269 - specifically items b, c, e, f, i, j, k, p, and q. See comments in the issue for details on these and the other items.
Put check around _VERSION to prevent nil from showing up at the start of the scenario.
Change warp damage threshold to stop largely extraneous message.
Comment out generic station entry and marketing Cruiser entry.
Fix improper good references.
Remove components.ai_controller line (not currently applicable).
Add differentiating context tags for report type lines related to goods.
Don't ask about cargo if ship is within 5 units.
Remove checks for the presence of players at consoles when adding custom widgets.

Put check around `_VERSION` to prevent nil from showing up at the start of the scenario.
Change warp damage threshold to stop largely extraneous message.
Comment out generic station entry and marketing Cruiser entry.
Fix improper good references.
Remove components.ai_controller line (not currently applicable)
Add differentiating context tags for report type lines related to goods.
Don't ask about cargo if ship is within 5 units.
Remove checks for the presence of players at consoles when adding custom widgets.
@daid daid merged commit e9bd31b into daid:master Jan 17, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants