Ensure adapter is created along with recyclerView #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrih
force-pushed
the
fix/grid-layout-adapter
branch
3 times, most recently
from
c48c632 to
904fc2d
Compare
vrih
force-pushed
the
fix/grid-layout-adapter
branch
from
904fc2d to
610bf4b
Compare
Fixes an error raised by RecyclerView: github.daneren2005.dsub E/RecyclerView: No adapter attached; skipping layout
vrih
force-pushed
the
fix/grid-layout-adapter
branch
from
610bf4b to
888e459
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When RecyclerView is first opened it doesn't have an adapter attached. This causes an error to be logged:
E/RecyclerView: No adapter attached; skipping layoutThe resolution seems to be to move most of the logic from
finishLoading()to just after view creation. I'm not quite familiar enough with the structure of the async data loads to fully DRY this up so I would appreciate a pointer or 2.I'm chasing down a bug that causes RecyclerView to not be properly cleaned up visually if the user exits the view before it has finished rendering and this is a candidate for causing it.