Merge pull request #122 from daniel-sc/121-invalid-attribute-name

fix: handle id with escaped characters - fixes #121
daniel-sc · Nov 27, 2024 · 51a6720 · 51a6720
2 parents d94509d + 9dad964
commit 51a6720
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/src/model/translationFileSerialization.spec.ts b/src/model/translationFileSerialization.spec.ts
@@ -294,7 +294,23 @@ describe('translationFileSerialization', () => {
   </file>
 </xliff>`);
         });
-        it('should output additinalAttribute', () => {
+        it('should output id with quotes', () => {
+            const input = new TranslationFile([{
+                id: 'idWithQuote"',
+                source: 'some source',
+                locations: []
+            }], 'en', 'de', '');
+            expect(toXlf1(input, {prettyNestedTags: true})).toEqual(`<xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2">
+  <file source-language="en" target-language="de" datatype="plaintext" original="ng2.template">
+    <body>
+      <trans-unit id="idWithQuote&quot;" datatype="html">
+        <source>some source</source>
+      </trans-unit>
+    </body>
+  </file>
+</xliff>`);
+        });
+        it('should output additionalAttribute', () => {
             const input = new TranslationFile([{
                 id: 'ID1',
                 source: 'source val',

diff --git a/src/model/translationFileSerialization.ts b/src/model/translationFileSerialization.ts
@@ -123,7 +123,8 @@ export function toXlf2(translationFile: TranslationFile, options: Pick<Options,
     }
     const file = doc.childNamed('file')!;
     file.children = translationFile.units.map(unit => {
-        const u = new XmlDocument(`<unit id="${unit.id}"><segment><source>${unit.source}</source></segment></unit>`);
+        const u = new XmlDocument(`<unit id=""><segment><source>${unit.source}</source></segment></unit>`);
+        u.attr.id = unit.id;
         const segment = u.childNamed('segment')!;
         if (unit.target !== undefined) {
             segment.children.push(new XmlDocument(`<target>${unit.target}</target>`));
@@ -171,9 +172,10 @@ export function toXlf1(translationFile: TranslationFile, options: Pick<Options,
     }
     const body = file.childNamed('body')!;
     body.children = translationFile.units.map(unit => {
-        const transUnit = new XmlDocument(`<trans-unit id="${unit.id}" datatype="html">
+        const transUnit = new XmlDocument(`<trans-unit id="" datatype="html">
         <source>${unit.source}</source>
 </trans-unit>`);
+        transUnit.attr.id = unit.id;
         if (unit.target !== undefined) {
             const target = new XmlDocument(`<target>${unit.target}</target>`);
             if (unit.state !== undefined) {