-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add lazyframe support for parquet and delta #52
feat: add lazyframe support for parquet and delta #52
Conversation
Hey @ion-elgreco, can we keep polars >= 0.18.0? Would it cause any harm? |
If you keep it at 0.18 you need to manually keep logic in to handle the different versions. Also the polars write delta is tied to a delta lake version, so that's why we need at least 0.20 because I made various changes to polars 0.19 In general also Ritchie advises to keep everything up to date so I don't see much harm in locking it to >=0.20, |
Sometimes upgrading is not so easy (I personally can't do it at work), it should be the end user's decision to upgrade unless absolutely required by the library. I don't think we can't support 0.18.0. Even 0.17.0 is working correctly with the latest deltalake. In fact, the CI in this repo will be run for all minor polars versions from 0.17 to 0.20, and this worked perfectly previously. We can remove the legacy pyarrow logic, that's fine. Is there any other version-dependent logic which would case any issues? Can you point out the specific issues with 0.18.0? |
@danielgafni alright, I've added support back for older polars versions, it's up to the users then. But we should drop older polars support once v1.0 lands. Maintaining code for multiple versions is not very practical : ) |
Looking at the test failures, polars==0.18 will be incompatible. I still think we need to drop that one at least otherwise we cannot release the changes |
bef18d3
to
44ae873
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work @ion-elgreco ! Thanks for this PR!
This PR exposes LazyFrame support to parquet and delta IO Managers:
dump_df_to_path
towrite_df_to_path
sink_df_to_path
dump_to_path
to handleLazyFrames
get_storage_options
since the UPathIOmanager already handles this with thestorage_options
property