Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect build_info metric introduced in 9df9db85 #474

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

hateeyan
Copy link
Contributor

Hi,

After upgrading to the latest version, I found that the kafka_exporter_build_info metric was missing.

It was modified in the 9df9db85 commit. We should use versionCollector.NewCollector instead of collectors.NewBuildInfoCollector.

@danielqsj
Copy link
Owner

/lgtm thanks @hateeyan

@danielqsj danielqsj merged commit 5ccad07 into danielqsj:master Feb 13, 2025
1 check passed
@hateeyan hateeyan deleted the build_info branch February 13, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants