fixed #342/#343 - do not treat directories like regular files in existence checks #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No tests added since we still do not have tests for additional files ... but I just realized that certain directories always exists so at least on Linux it can be tested. Moving code is problematic though as Cppcheck is GPL and this would re-license it under 0BSD. |
firewave
force-pushed
the
inc
branch
5 times, most recently
from
3ead71c to
fa994a3
Compare
After we resolved and merged this we should create another release so we can sync it to Cppcheck. |
firewave
changed the title
|
The helper functions need to be adjusted so they align with the current usage in Cppcheck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::ifstreamcan open directories and read from them without issue. Nothing will be read though - it is like an empty file. This would have treated an include which actually pointed to a directory as existing (e.g.#include </>).