Add mypy & type annotations. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJCLaw
force-pushed
the
type-annotations
branch
5 times, most recently
from
be46108 to
824915d
Compare
This is fairly light on config and doesn't attempt to add any type checking just yet, but does get mypy running in CI and passing.
PeterJCLaw
force-pushed
the
type-annotations
branch
3 times, most recently
from
e94f64d to
d6e6c14
Compare
This gets the tests passing type checking without requiring that they're fully annotated.
Grandfather in a couple of exceptions.
PeterJCLaw
force-pushed
the
type-annotations
branch
from
d6e6c14 to
03164bd
Compare
Closed
danpalmer
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds almost complete type annotation coverage. The remaining items are
nodb_cursorwhich isn't trivial to type and doesn't get a lot of value from being typed and theFactoryStrategywhich I believe is incomplete anyway.