Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement _check #2351

Closed
wants to merge 2 commits into from
Closed

Implement _check #2351

wants to merge 2 commits into from

Conversation

mahim-18
Copy link

Solved the "good first issue" #1

Changes Made :

Made changes in calculator.test.js
describe('_check', () => { beforeEach(() => { sinon.spy(calculator, '_check'); });
This is done so that all the tests can run at a same time

Moved the repeating function for checking the TypeError once globally and using it at all the checks.
Screenshot 2024-11-13 at 7 41 48 PM

This helped me gain some knowledge about how such tests are made for checking if all functionalities are working as desired.

@dantharejabot
Copy link
Collaborator

Thanks for the submission, @mahim-18.

As mentioned in the contributing guidelines, I can only accept a pull request made to your branch.

This is a weird requirement, but it's necessary here in order to allow multiple people to contribute the same code. In the real world, most projects would expect you to open a Pull Request against the master base branch.

Click here to open this pull request to your branch

Want to contribute to the master branch? Open an issue in the partner repo and let's talk.

dantharejabot added a commit that referenced this pull request Nov 13, 2024
 Implement _check (After resloving lint issues too) #2351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants