Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement_check #2379

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Implement_check #2379

merged 3 commits into from
Dec 25, 2024

Conversation

kuhuisien
Copy link

This pull request addressed issue #1 by optimized calculators.js to remove duplicated code.

Note: My code editor’s formatting settings caused unintended formatting changes, which I reverted in my last commit.

To prevent such issues in the future, I’d like to ask:
Would it be helpful if I add a .prettierrc file to standardize formatting preferences across the team?

Looking forward to your feedback!

@dantharejabot
Copy link
Collaborator

Yay, a pull request!

After you submit a pull request, one of the following will happen:

😭 You don’t get a response. 😭

Even on an active project, it’s possible that your pull request won’t get an immediate response. You should expect some delay as most open source maintainers do so in their free time and can be busy with other tasks.

If you haven’t gotten a response in over a week, it’s fair to politely respond in the same thread, asking someone for a review. If you know the handle of the right person to review your pull request, you can @-mention them to send them a notification. Avoid reaching out to that person privately; remember that public communication is vital to open source projects.

If you make a polite bump and still nobody responds, it’s possible that nobody will respond, ever. It’s not a great feeling, but don’t let that discourage you. It’s happened to everyone! There are many possible reasons why you didn’t get a response, including personal circumstances that may be out of your control. Try to find another project or way to contribute. If anything, this is a good reason not to invest too much time in making a pull request before other community members are engaged and responsive.

🚧 You're asked to make changes to your pull request. 🚧

It’s very common that someone will request changes on your pull request, whether that’s feedback on the scope of your idea, or changes to your code. Often a pull request is just the start of the conversation.

When someone requests changes, be responsive. They’ve taken the time to review your pull request. Opening a PR and walking away is bad form. If you don’t know how to make changes, research the problem, then ask for help if you need it.

If you don’t have time to work on the issue anymore (for example, if the conversation has been going on for months, and your circumstances have changed), let the maintainer know so they’re not expecting a response. Someone else may be happy to take over.

👎 Your pull request doesn’t get accepted. 👎

It's possible your pull request may or may not be accepted in the end. If you’re not sure why it wasn’t accepted, it’s perfectly reasonable to ask the maintainer for feedback and clarification. Ultimately, however, you’ll need to respect that this is their decision. Don’t argue or get hostile. You’re always welcome to fork and work on your own version if you disagree!

🎉 Your pull request gets accepted and merged. 🎉

Hooray! You’ve successfully made an open source contribution!

Thank you for the submission, @kuhuisien! I'll review your code shortly, hang tight.

dantharejabot
dantharejabot requested changes Dec 25, 2024
View reviewed changes
Copy link
Collaborator

@dantharejabot dantharejabot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great attempt, @kuhuisien!

I would like to request a few changes before merging your work. Please review my comments below and make the appropriate changes to your code.

After you update your code locally, follow the instructions to save your changes locally and push your changes to your fork.

When you push your changes to your fork, I'll come back for another review.

There are 34 style guide violations in your contribution. I've marked them with inline comments for your convenience.

Please revisit your code and follow the style guide best practices.

Hint: You might be able to fix some issues automatically by running npm run lint -- --fix

All the tests are passing. Nice job!

src/calculator.test.js Outdated
@@ -1,20 +1,20 @@
/* eslint-disable no-unused-expressions */
const calculator = require('./calculator');
const calculator = require("./calculator");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote.
(learn more)

src/calculator.test.js Outdated

describe.skip('_check', () => {
describe("_check", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote.
(learn more)

src/calculator.test.js Outdated
beforeEach(() => {
sinon.spy(calculator, '_check');
sinon.spy(calculator, "_check");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote.
(learn more)

src/calculator.test.js Outdated
});

afterEach(() => {
calculator._check.restore();
});

it('should throw a TypeError if arguments are not numbers', () => {
expect(() => calculator._check(40, '2')).to.throw(TypeError);
it("should throw a TypeError if arguments are not numbers", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote.
(learn more)

src/calculator.test.js Outdated
it('should throw a TypeError if arguments are not numbers', () => {
expect(() => calculator._check(40, '2')).to.throw(TypeError);
it("should throw a TypeError if arguments are not numbers", () => {
expect(() => calculator._check(40, "2")).to.throw(TypeError);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote.
(learn more)

src/calculator.test.js Outdated
expect(() => calculator.subtract(40, '2')).to.throw(TypeError);
describe("subtract", () => {
it("should throw a TypeError if arguments are not numbers", () => {
expect(() => calculator.subtract(40, "2")).to.throw(TypeError);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote.
(learn more)

src/calculator.test.js Outdated
expect(() => calculator.subtract(40, [])).to.throw(TypeError);
expect(() => calculator.subtract(40, {})).to.throw(TypeError);
expect(() => calculator.subtract('40', 2)).to.throw(TypeError);
expect(() => calculator.subtract("40", 2)).to.throw(TypeError);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote.
(learn more)

src/calculator.test.js Outdated
expect(() => calculator.subtract([], 2)).to.throw(TypeError);
expect(() => calculator.subtract({}, 2)).to.throw(TypeError);
});

it('should subtract two positive numbers', () => {
it("should subtract two positive numbers", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote.
(learn more)

src/calculator.test.js Outdated
expect(calculator.subtract(44, 2)).to.equal(42);
});

it('should subtract two negative numbers', () => {
it("should subtract two negative numbers", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote.
(learn more)

src/calculator.test.js Outdated
expect(calculator.subtract(-44, -2)).to.equal(-42);
});

it('should subtract one positive number and one negative number', () => {
it("should subtract one positive number and one negative number", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote.
(learn more)

@dantharejabot
Copy link
Collaborator

✨ Changes synced ✨

When a pull request is open, GitHub tracks changes to the branch it was opened from. As you push changes to your fork's master branch, you'll automatically see them here.

Thanks for the changes, @kuhuisien. I'm reviewing them now.

dantharejabot
dantharejabot approved these changes Dec 25, 2024
View reviewed changes
Copy link
Collaborator

@dantharejabot dantharejabot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for your contribution @kuhuisien!

Your code style completely follows the style guide. Nice job!

All the tests are passing. Nice job!

@dantharejabot dantharejabot merged commit 6ffa60c into danthareja:kuhuisien Dec 25, 2024
@dantharejabot
Copy link
Collaborator

🎉 You did it! 🎉

You're an open source contributor now!

Whether this was your first pull request, or you’re just looking for new ways to contribute, I hope you’re inspired to take action. Don't forget to say thanks when a maintainer puts effort into helping you, even if a contribution doesn't get accepted.

Open source is made by people like you: one issue, pull request, comment, and +1 at a time.

What's next?

Find your next project:

Learn from other great community members:

Elevate your Git game:

  • Try Git - an interactive tutorial made by GitHub
  • Learn Git - video and written lessons for the command line and desktop client
  • Learn Git Branching - an interactive tutorial diving deep into branching
  • GitHub Flow - a video explaining the pull request process on GitHub

Questions? Comments? Concerns?

I'm always open to feedback. If you had a good time with the exercise, or found some room for improvement, please email me.

Want to start over? Just delete your fork.
Want to see behind the scenes? Check out the server code.

@kuhuisien
Copy link
Author

Thanks for the feedback!

Just wanted to quickly follow up on something I mentioned earlier – would it be helpful if I added a .prettierrc file to standardise formatting preferences across the team?

Looking forward to your input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantharejabot dantharejabot dantharejabot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhuisien @dantharejabot