docs: add jobs overwrite flag #4646
Open
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Aliaga <[email protected]>
javier-aliaga
changed the title
msfussell
reviewed
May 7, 2025
There was a problem hiding this comment.
@javier-aliaga - Commented. A few things
-
Please put the code issue into the docs issue. I have added it in this case (Don't overwrite jobs using same name dapr#8402)
-
Let's use this PR to update docs overview here https://docs.dapr.io/developing-applications/building-blocks/jobs/jobs-overview/
- Under Features we really should say that the primary feature here is to create, get and delete jobs. This can be one paragraph, but in that paragraph you should mention that an existing job cannot be overwritten unless specific indicated. Write something and I will review this
- The first sentence here is now wrong I presume https://docs.dapr.io/developing-applications/building-blocks/jobs/jobs-overview/ under "Schedule jobs across multiple replicas" - where is says "When you create a job, it replaces any existing job with the same name." Should now say "When you create a job, it does not replace an existing job with the same name, unless you explicitly set the 'overwrite' flag"
- Remove the "waiting on code" label once this code is merged.
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
msfussell
added
the
waiting-on-code-pr
…bs/jobs-features-concepts.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
7 tasks
Signed-off-by: Javier Aliaga <[email protected]>
JoshVanL
requested changes
May 15, 2025
| @@ -115,6 +114,7 @@ POST request to the endpoint `/job/<job-name>`. The body includes the following | |||
| or the not-before time from which the schedule should take effect | |||
| - `Ttl`: An optional value indicating when the job should expire | |||
| - `Payload`: A collection of bytes containing data originally stored when the job was scheduled | |||
| - `Overwrite`: An optional flag to allow the job to overwrite an existing job with the same name | |||
There was a problem hiding this comment.
nit: the API is not an optional || pointer in the API.
Suggested change
| - `Overwrite`: An optional flag to allow the job to overwrite an existing job with the same name | |
| - `Overwrite`: A flag to allow the requested job to overwrite an existing job with the same name, if it already exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Issue reference
Issue - dapr/dapr#8402
PR - dapr/dapr#8701