Skip to content

Cleaup Test Dependencies #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

siri-varma
Copy link
Contributor

@siri-varma siri-varma commented May 5, 2025

Description

  • I think having all the versions defined in the parent pom is a good idea.
  • Moved the versions for testcontainer-module and spring-boot-example to parent pom. Depending on the feedback from this PR will work on rest of the modules in later prs.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #940

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@siri-varma siri-varma requested review from a team as code owners May 5, 2025 14:33
Signed-off-by: sirivarma <[email protected]>
@artur-ciocanu
Copy link
Contributor

@siri-varma it seems that there are so missing classes after your POM changes and there some NoSuchMethodError messages in logs.

@siri-varma siri-varma changed the title Users/svegiraju/pom cleanup 3 Cleaup Test Dependencies May 5, 2025
@siri-varma
Copy link
Contributor Author

@artur-ciocanu Yes. Still working on fixing this

siri-varma added 4 commits May 5, 2025 09:49
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
@siri-varma
Copy link
Contributor Author

siri-varma commented May 5, 2025

@artur-ciocanu @salaboy @cicoyle This PR is ready to be reviewed. Thank you

@salaboy
Copy link
Collaborator

salaboy commented May 6, 2025

@artur-ciocanu do you have any comments about this? Because the Dapr SDK is split into two big things (modules and sdk-tests), I believe that it was ok to do dependency management separately, as dependencies needed in the sdk-tests are not needed in the SDK itself (like toxy proxy). But if we are moving towards a world where we have all the SDK tests as testcontainer tests, this makes sense.

@salaboy
Copy link
Collaborator

salaboy commented May 6, 2025

@siri-varma to be clear.. I am not against this.. I am just thinking a bit long term how this will work out.

Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.36%. Comparing base (d759c53) to head (baa7dcd).
Report is 137 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1332      +/-   ##
============================================
+ Coverage     76.91%   77.36%   +0.45%     
- Complexity     1592     1764     +172     
============================================
  Files           145      204      +59     
  Lines          4843     5368     +525     
  Branches        562      587      +25     
============================================
+ Hits           3725     4153     +428     
- Misses          821      902      +81     
- Partials        297      313      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor maven POMs to put all information about the dependencies/plugins in the root POM
3 participants