-
Notifications
You must be signed in to change notification settings - Fork 217
Cleaup Test Dependencies #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Cleaup Test Dependencies #1332
Conversation
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
@siri-varma it seems that there are so missing classes after your POM changes and there some |
@artur-ciocanu Yes. Still working on fixing this |
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
@artur-ciocanu @salaboy @cicoyle This PR is ready to be reviewed. Thank you |
@artur-ciocanu do you have any comments about this? Because the Dapr SDK is split into two big things (modules and sdk-tests), I believe that it was ok to do dependency management separately, as dependencies needed in the sdk-tests are not needed in the SDK itself (like toxy proxy). But if we are moving towards a world where we have all the SDK tests as testcontainer tests, this makes sense. |
@siri-varma to be clear.. I am not against this.. I am just thinking a bit long term how this will work out. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1332 +/- ##
============================================
+ Coverage 76.91% 77.36% +0.45%
- Complexity 1592 1764 +172
============================================
Files 145 204 +59
Lines 4843 5368 +525
Branches 562 587 +25
============================================
+ Hits 3725 4153 +428
- Misses 821 902 +81
- Partials 297 313 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #940
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: