-
Notifications
You must be signed in to change notification settings - Fork 217
Cleanup Spring Dependencies #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Cleanup Spring Dependencies #1334
Conversation
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siri-varma I've left some comments .. I do recommend not having the springframework.version managed in this way.. it will make it really hard to maintain.
Signed-off-by: sirivarma <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1334 +/- ##
============================================
+ Coverage 76.91% 77.42% +0.50%
- Complexity 1592 1764 +172
============================================
Files 145 204 +59
Lines 4843 5368 +525
Branches 562 587 +25
============================================
+ Hits 3725 4156 +431
- Misses 821 899 +78
- Partials 297 313 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #940
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: