Add WithSliceDeepMerge option #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Open
sunsingerus
force-pushed
the
WithSliceDeepMerge
branch
from
1094edd to
4c25c5b
Compare
sunsingerus
force-pushed
the
WithSliceDeepMerge
branch
from
4c25c5b to
7cab6cf
Compare
sunsingerus
force-pushed
the
WithSliceDeepMerge
branch
from
7cab6cf to
fc6fffa
Compare
|
issues noted by codeclimate addressed |
|
commits squashed for clarify |
|
Hello @imdario, can you please suggest, what next steps should be taken in order to move on with this PR? |
|
@sunsingerus I'll review during the weekend. |
|
@imdario any news about this PR? |
|
@Slach I had no opportunity to review it in depth. I won't be able to try again until August as I'm getting married. |
|
Sorry but adding more complexity to that condition in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #233.
Introduce new option
mergo.WithSliceDeepMergewhich can be tuned withmergo.WithOverrideormergo.WithOverwriteWithEmptyValue.Test cases are provided in
issue233_test.goformergo.WithSliceDeepMergeand combinations withmergo.WithOverrideormergo.WithOverwriteWithEmptyValue.Test are being run successfully with
go test.