Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Makernotes handling: #302

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

LibRaw
Copy link
Contributor

@LibRaw LibRaw commented Sep 5, 2021

  1. Skip (known) LSI1 binary makernotes
  2. Check IFD Entries count against tag data count, skip if too big

This should fix #283

 1) Skip (known) LSI1 binary makernotes
 2) Check IFD Entries count against tag data count, skip if too big
@@ -159,7 +160,9 @@ TiffRootIFDOwner TiffIFD::parseMakerNote(NORangesSet<Buffer>* ifds,
bs.skipBytes(newPosition);
};

if (bs.hasPrefix("AOC\0", 4)) {
if (bs.hasPrefix("LSI1\0", 5)) { // Skip LSI1 makernotes
Copy link
Contributor

@kmilos kmilos Sep 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe be more verbose in the comments that this indicates "LaserSoft Imaging (SilverFast)" for posterity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the text of the comment is the only thing that prevents Roman from accepting this patch, then I will certainly change it. Let's wait for his opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exif data from Silverfast DNG causes rawspeed to fail
3 participants