TiffParser::parse(): retain already-parsed IFD's on IFD parse failure (Blackmagic oddities) #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (Blackmagic oddities) This happens in some Blackmagic cases: ``` ./Blackmagic Design/Pocket Cinema Camera 6k Pro/A010_04101355_S068.dng: starting decoding ... ./Blackmagic Design/Pocket Cinema Camera 6k Pro/A010_04101355_S068.dng failed: virtual std::unique_ptr<RawDecoder> rawspeed::RawParser::getDecoder(const CameraMetaData *), line 97: No decoder found. Sorry. ./Blackmagic/Blackmagic Pocket Cinema Camera 4k/4k_DCI_uncompressed.dng: starting decoding ... ./Blackmagic/Blackmagic Pocket Cinema Camera 4k/4k_DCI_uncompressed.dng failed: virtual std::unique_ptr<RawDecoder> rawspeed::RawParser::getDecoder(const CameraMetaData *), line 97: No decoder found. Sorry. ./Blackmagic/Blackmagic Pocket Cinema Camera 4k/BMPCC_4k_DCI_uncompressed.dng: starting decoding ... ./Blackmagic/Blackmagic Pocket Cinema Camera 4k/BMPCC_4k_DCI_uncompressed.dng failed: virtual std::unique_ptr<RawDecoder> rawspeed::RawParser::getDecoder(const CameraMetaData *), line 97: No decoder found. Sorry. ``` ... these now decode successfully, but the rest do not: ``` ./Blackmagic/Blackmagic Pocket Cinema Camera 4k/BMPCC_4k_DCI_3-1.dng: starting decoding ... ./Blackmagic/Blackmagic Pocket Cinema Camera 4k/BMPCC_4k_DCI_3-1.dng failed: void rawspeed::AbstractDngDecompressor::decompress() const, line 249: Too many errors encountered. Giving up. First Error: void rawspeed::AbstractLJpegDecoder::decodeSOI(), line 111: Not a valid RAW file. ./Blackmagic/Blackmagic Pocket Cinema Camera 4k/BMPCC_4k_DCI_4-1.dng: starting decoding ... ./Blackmagic/Blackmagic Pocket Cinema Camera 4k/BMPCC_4k_DCI_4-1.dng failed: void rawspeed::AbstractDngDecompressor::decompress() const, line 249: Too many errors encountered. Giving up. First Error: void rawspeed::AbstractLJpegDecoder::decodeSOI(), line 111: Not a valid RAW file. ``` <- `define quantization tables`. WHY? ``` ./Blackmagic/Blackmagic Pocket Cinema Camera 4k/BMPCC_4k_DCI_lossless.dng: starting decoding ... ./Blackmagic/Blackmagic Pocket Cinema Camera 4k/BMPCC_4k_DCI_lossless.dng failed: void rawspeed::AbstractDngDecompressor::decompress() const, line 249: Too many errors encountered. Giving up. First Error: virtual Buffer::size_type rawspeed::LJpegDecoder::decodeScan(), line 108: Unsupported predictor mode: 6 ./Blackmagic/Pocket Cinema Camera/Blackmagic_Pocket_Cinema_Camera_1_2016-09-17_0053_C0022_000007.dng: starting decoding ... ./Blackmagic/Pocket Cinema Camera/Blackmagic_Pocket_Cinema_Camera_1_2016-09-17_0053_C0022_000007.dng failed: void rawspeed::AbstractDngDecompressor::decompress() const, line 249: Too many errors encountered. Giving up. First Error: virtual Buffer::size_type rawspeed::LJpegDecoder::decodeScan(), line 108: Unsupported predictor mode: 6 ./Blackmagic/URSA 4K/Blackmagic URSA_1_1999-12-31_2153_C0003_000001.dng: starting decoding ... ./Blackmagic/URSA 4K/Blackmagic URSA_1_1999-12-31_2153_C0003_000001.dng failed: void rawspeed::AbstractDngDecompressor::decompress() const, line 249: Too many errors encountered. Giving up. First Error: virtual Buffer::size_type rawspeed::LJpegDecoder::decodeScan(), line 108: Unsupported predictor mode: 6 ``` <- sound promising, but we'll see...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens in some Blackmagic cases:
... these now decode successfully, but the rest do not:
<-
define quantization tables. WHY?<- sound promising, but we'll see...