Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alias for Fujifilm FinePix S9600fd #732

Merged

Conversation

victoryforce
Copy link
Contributor

Fix for correct syntax of Alias, thanks to @kmilos.

@victoryforce victoryforce requested a review from LebedevRI as a code owner June 14, 2024 09:38
@kmilos
Copy link
Collaborator

kmilos commented Jun 14, 2024

To clarify: you use both real value and clean id attribute when you want to normalize/prettify the actual string from the Exif Model tag, like we usually do for Canons to avoid the duplicate "Canon Canon" when concatenating Make + Model:

rawspeed/data/cameras.xml

Lines 110 to 113 in 8d343c0

<Aliases>
<Alias id="EOS Rebel SL1">Canon EOS REBEL SL1</Alias>
<Alias id="EOS Kiss X7">Canon EOS Kiss X7</Alias>
</Aliases>

Since the Exif Model string is already "clean" for Fujifilms, there is no need for both.

@LebedevRI LebedevRI merged commit 3d7f175 into darktable-org:develop Jun 14, 2024
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants