This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
Change ShadowBoundary to ignore duplicate styles #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| final WebPlatformShim platformShim; | ||
| final ComponentCssRewriter componentCssRewriter; | ||
| final dom.NodeTreeSanitizer treeSanitizer; | ||
| final Map<_ComponentAssetKey, async.Future<dom.StyleElement>> styleElementCache; |
There was a problem hiding this comment.
Does all of those fields need to be public ?
chirayuk
force-pushed
the
master
branch
2 times, most recently
from
8fd235c to
50e2645
Compare
vsavkin
force-pushed
the
shadow_boundary_ignore_duplicate_styles
branch
from
cf2c496 to
01b9c22
Compare
…ents * Extract ComponentCssLoader so it can be shared by ShadowDomComponentFactory and TranscludingComponentFactory * Provide a built-in implementation of WebPlatformShim using css_shim * Implement a CSS transformer similar to the one provided by Platform.JS * Rename EventHandler into ShadowBoundary
vsavkin
force-pushed
the
shadow_boundary_ignore_duplicate_styles
branch
from
01b9c22 to
5b04b17
Compare
vsavkin
added a commit
that referenced
this pull request
Sep 11, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style elements are inserted at a shadow boundary. This means the style elements of a transcluding component will be inserted at the top of the closest shadow dom component.
This PR changes ShadowBoundary to remember what style elements have already been inserted. This means that a shadow-dom component that has hundreds of transcluding components (e.g., a table) will have only one style element instead of hundreds.
Depends on #1315